vance/ryujinx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix LocaleExtension SetRawSource usages + language perf improvement (#7121)

Browse Source 
* Avoid Avalonia CompiledBindingPathBuilder.SetRawSource

* Improve UI language change performance
This commit is contained in:
Julien Lebosquain 2024-08-04 20:04:12 +02:00 committed by GitHub
parent 42f22fe5d7
commit e85ee673b1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Ryujinx/Common/Locale/LocaleExtension.cs
View File

@ -21,7 +21,7 @@ namespace Ryujinx.Ava.Common.Locale
var builder = new CompiledBindingPathBuilder(); var builder = new CompiledBindingPathBuilder();
builder.SetRawSource(LocaleManager.Instance) builder
.Property(new ClrPropertyInfo("Item", .Property(new ClrPropertyInfo("Item",
obj => (LocaleManager.Instance[keyToUse]), obj => (LocaleManager.Instance[keyToUse]),
null, null,
@ -32,7 +32,10 @@ namespace Ryujinx.Ava.Common.Locale
var path = builder.Build(); var path = builder.Build();
var binding = new CompiledBindingExtension(path); var binding = new CompiledBindingExtension(path)
{
Source = LocaleManager.Instance
};
return binding.ProvideValue(serviceProvider); return binding.ProvideValue(serviceProvider);
} }

4
src/Ryujinx/Common/Locale/LocaleManager.cs
View File

@ -139,9 +139,11 @@ namespace Ryujinx.Ava.Common.Locale
foreach (var item in locale) foreach (var item in locale)
{ {
this[item.Key] = item.Value; _localeStrings[item.Key] = item.Value;
} }
OnPropertyChanged("Item");
LocaleChanged?.Invoke(); LocaleChanged?.Invoke();
} }